feat(*) add kafka protocol suport #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
| func (c *KafkaConfigurer) Configure(filterChain *envoy_listener.FilterChain) error { | ||
| pbst, err := proto.MarshalAnyDeterministic( | ||
| &envoy_kafka.KafkaBroker{ | ||
| StatPrefix: kafkaStatPrefix, |
There was a problem hiding this comment.
This should be listener name, look at TCP Proxy stat prefix and pass the same value
| kafkaStatPrefix = "kstat" | ||
| ) | ||
|
|
||
| func Kafka() FilterChainBuilderOpt { |
There was a problem hiding this comment.
We need to convert kafka stats to have proper prometheus metrics with two labels
- TYPE
- name (from stats prefix)
added 2 commits
November 3, 2020 14:43
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
nickolaev
force-pushed
the
feat/kafka_support
branch
from
ae215e1
to
21673e5
Compare
jakubdyszkiewicz
approved these changes
Nov 3, 2020
added 2 commits
November 3, 2020 17:18
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add support for Kafka protocol statistics as per https://www.envoyproxy.io/docs/envoy/latest/configuration/listeners/network_filters/kafka_broker_filter#statistics
Prometheus statistics as follows:
Documentation