Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(*) choose the namespace when install dns #1128

Merged
merged 3 commits into from
Nov 9, 2020
Merged

chore(*) choose the namespace when install dns #1128

merged 3 commits into from
Nov 9, 2020

Conversation

nickolaev
Copy link
Contributor

@nickolaev nickolaev commented Nov 5, 2020 •
edited

Summary

Add kumactl install dns --namespace to set where to find the kuma-cp service.

Issues resolved

Fix #1126

Documentation

  • kumactl install dns --help

Nikolay Nikolaev added 2 commits November 5, 2020 10:25
fix(*) pod controller remove hard-coded "kuma-system"
4863ff1 
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
fix(*) add kumactl install dns --namespace
716266c 
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
@nickolaev nickolaev requested a review from a team as a code owner November 5, 2020 15:48
fix(*) review
22f1ca3 
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
@nickolaev nickolaev merged commit 1725f5d into master Nov 9, 2020
@nickolaev nickolaev deleted the chore/install_dns_namespace branch November 9, 2020 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kumactl install dns assumes kuma-system namespace
2 participants
@nickolaev @jakubdyszkiewicz