chore(kuma-cp) more descriptive KDS logging #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
nickolaev
approved these changes
Nov 11, 2020
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
lobkovilya
reviewed
Nov 16, 2020
| @@ -47,10 +47,12 @@ func (s *kdsSink) Start(stop <-chan struct{}) (errs error) { | |||
|
|
|||
| clusterID, rs, err := s.kdsStream.Receive() | |||
| if err != nil { | |||
| if err == io.EOF { | |||
| break | |||
There was a problem hiding this comment.
Why do we break on EOF? I guess s.kdsStream.Receive() on the next iteration will return EOF as well
There was a problem hiding this comment.
There won't be the next iteration without this if, it will use
return errors.Wrap(err, "failed to receive a discovery response")
lobkovilya
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A couple of improvements to KDS logging
DiscoveryRequest,ACK,NACKetc. should be hidden on debug level just like it is for data plane exchangeIssues resolved
Fix #1081
Documentation