control-plane: add selector to ProxyTemplate #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubdyszkiewicz
approved these changes
Aug 16, 2019
| }), | ||
| Entry("both selector and target are empty", testCase{ | ||
| selector: nil, | ||
| target: nil, |
There was a problem hiding this comment.
should selector and target be an empty map? if not then this test case and above can be merged
There was a problem hiding this comment.
yeah, it's a typo (should be map[string]string{}).
Thanks!
| return r.DefaultProxyTemplate | ||
| } | ||
|
|
||
| func FindBestMatch(proxy *model.Proxy, templates []*mesh_core.ProxyTemplateResource) *mesh_core.ProxyTemplateResource { |
There was a problem hiding this comment.
Some comment would be nice here like:
// For template to match, it has to match all tags of any inbound of the dataplane.
// Matched templates are scored by the number of tags.
// Template without any tag is a match but has a score of 0.
// If there are multiple templates with the same score, the first one is picked (by alphabetic order)
WDYT?
yskopets
changed the base branch from
feature/add-konvoyctl-get-proxytemplates
to
master
yskopets
force-pushed
the
feature/add-selector-to-proxytemplate
branch
from
ea8e791
to
185fc8c
Compare
yskopets
force-pushed
the
feature/add-selector-to-proxytemplate
branch
from
185fc8c
to
0601c95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes:
selectorstoProxyTemplatesourcesintoconfDataplane, pickProxyTemplatewith the highest number of matching key-value pairs