Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(helm) new helm 3.4.1 linter fail #1147

Merged
merged 2 commits into from
Nov 12, 2020
Merged

fix(helm) new helm 3.4.1 linter fail #1147

merged 2 commits into from
Nov 12, 2020

Conversation

nickolaev
Copy link
Contributor

Summary

The latest Helm 3.4.1 is a bit more strict about naming, so the linter of our charts fails:

==> Linting ./deployments/charts/kuma
[ERROR] templates/cp-rbac.yaml: object name does not conform to Kubernetes naming requirements: "kuma:control-plane": invalid metadata name, must match regex ^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$ and the length must not be longer than 253
[ERROR] templates/cp-rbac.yaml: object name does not conform to Kubernetes naming requirements: "kuma:control-plane": invalid metadata name, must match regex ^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$ and the length must not be longer than 253
[ERROR] templates/cp-rbac.yaml: object name does not conform to Kubernetes naming requirements: "kuma:control-plane": invalid metadata name, must match regex ^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$ and the length must not be longer than 253
[ERROR] templates/cp-rbac.yaml: object name does not conform to Kubernetes naming requirements: "kuma:control-plane": invalid metadata name, must match regex ^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$ and the length must not be longer than 253
[ERROR] templates/pre-delete-webhooks.yaml: object name does not conform to Kubernetes naming requirements: "kuma:pre-delete-job": invalid metadata name, must match regex ^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$ and the length must not be longer than 253
[ERROR] templates/pre-delete-webhooks.yaml: object name does not conform to Kubernetes naming requirements: "kuma:pre-delete-job": invalid metadata name, must match regex ^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$ and the length must not be longer than 253
[ERROR] templates/pre-install-patch-namespace-job.yaml: object name does not conform to Kubernetes naming requirements: "kuma:patch-ns-job": invalid metadata name, must match regex ^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$ and the length must not be longer than 253
[ERROR] templates/pre-install-patch-namespace-job.yaml: object name does not conform to Kubernetes naming requirements: "kuma:patch-ns-job": invalid metadata name, must match regex ^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$ and the length must not be longer than 253

Error: 1 chart(s) linted, 1 chart(s) failed

Fixing it here.

fix(helm) new helm 3.4.1 linter fail
2a61690 
```
==> Linting ./deployments/charts/kuma
[ERROR] templates/cp-rbac.yaml: object name does not conform to Kubernetes naming requirements: "kuma:control-plane": invalid metadata name, must match regex ^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$ and the length must not be longer than 253
[ERROR] templates/cp-rbac.yaml: object name does not conform to Kubernetes naming requirements: "kuma:control-plane": invalid metadata name, must match regex ^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$ and the length must not be longer than 253
[ERROR] templates/cp-rbac.yaml: object name does not conform to Kubernetes naming requirements: "kuma:control-plane": invalid metadata name, must match regex ^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$ and the length must not be longer than 253
[ERROR] templates/cp-rbac.yaml: object name does not conform to Kubernetes naming requirements: "kuma:control-plane": invalid metadata name, must match regex ^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$ and the length must not be longer than 253
[ERROR] templates/pre-delete-webhooks.yaml: object name does not conform to Kubernetes naming requirements: "kuma:pre-delete-job": invalid metadata name, must match regex ^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$ and the length must not be longer than 253
[ERROR] templates/pre-delete-webhooks.yaml: object name does not conform to Kubernetes naming requirements: "kuma:pre-delete-job": invalid metadata name, must match regex ^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$ and the length must not be longer than 253
[ERROR] templates/pre-install-patch-namespace-job.yaml: object name does not conform to Kubernetes naming requirements: "kuma:patch-ns-job": invalid metadata name, must match regex ^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$ and the length must not be longer than 253
[ERROR] templates/pre-install-patch-namespace-job.yaml: object name does not conform to Kubernetes naming requirements: "kuma:patch-ns-job": invalid metadata name, must match regex ^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$ and the length must not be longer than 253

Error: 1 chart(s) linted, 1 chart(s) failed
```

Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
@nickolaev nickolaev requested a review from a team as a code owner November 12, 2020 06:40
fix(*) tests
37629cc 
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
@nickolaev nickolaev merged commit 935162c into master Nov 12, 2020
@nickolaev nickolaev deleted the fix/helm_lint branch November 12, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lobkovilya lobkovilya lobkovilya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nickolaev @lobkovilya