added db stat metrics #1176
Merged
added db stat metrics #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tharun208
commented
Nov 19, 2020
tharun208
commented
Nov 19, 2020
Fixes kumahq#1068 Signed-off-by: Tharun <rajendrantharun@live.com>
tharun208
force-pushed
the
feat/db_stats
branch
from
4f2ba95
to
6cc9665
Compare
jakubdyszkiewicz
requested changes
Nov 20, 2020
tharun208
force-pushed
the
feat/db_stats
branch
from
2bc0b5d
to
461aa37
Compare
added method BulkRegister in metrics Interface fixed integration test Signed-off-by: Tharun <rajendrantharun@live.com>
tharun208
force-pushed
the
feat/db_stats
branch
from
461aa37
to
094c57f
Compare
jakubdyszkiewicz
requested changes
Nov 24, 2020
| @@ -267,3 +274,94 @@ func (r *resourceMetaObject) GetCreationTime() time.Time { | |||
| func (r *resourceMetaObject) GetModificationTime() time.Time { | |||
| return r.ModificationTime | |||
| } | |||
|
|
|||
| func registerAndCollectMetrics(metrics core_metrics.Metrics, dbStats sql.DBStats) error { | |||
There was a problem hiding this comment.
Again - you are only collecting the initial metrics about the DB. You need to do db.Stats() inside the closures.
Also change the name for registerMetrics
| db, err := common_postgres.ConnectToDb(config) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| if err := registerAndCollectMetrics(metrics, db.Stats()); err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
add context to the error - could not register DB metrics
Signed-off-by: Tharun <rajendrantharun@live.com>
jakubdyszkiewicz
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tharun rajendrantharun@live.com
Summary
Db Stat Metrics
Full changelog
Issues resolved
Fix #1068
Documentation