Validate mesh existence #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yskopets
reviewed
Aug 22, 2019
components/konvoy-control-plane/pkg/xds/server/proxy_template_resolver_test.go
Outdated
Show resolved
Hide resolved
components/konvoy-control-plane/pkg/xds/server/components_test.go
Outdated
Show resolved
Hide resolved
yskopets
approved these changes
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing intermediate layer between resource store which is persistence layer and api server layer/business layer. I expect this to be used instead of resource store in business logic, so we can add later other stuff like for example logging/auditing, security etc.
For now I just added mesh validation when saving resources.