control-plane: introduce a concept of SecretStore #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) | ||
|
|
||
| type Secret = core_system.SecretResource | ||
| type SecretList = core_system.SecretResourceList |
There was a problem hiding this comment.
Why do we need aliases here?
There was a problem hiding this comment.
aliases have been removed
| } | ||
|
|
||
| func (s *secretManager) encrypt(secret *secret_model.Secret) error { | ||
| if 0 < len(secret.Spec.Value) { |
There was a problem hiding this comment.
super-nitpicking-and-question-about-style:
Why
if 0 < len(secret.Spec.Value)
and not
if len(secret.Spec.Value) > 0
The latter is more natural to me with former I need to stretch my brain just a tiny bit.
There was a problem hiding this comment.
replaced with if len(secret.Spec.Value) > 0
| @@ -0,0 +1,14 @@ | |||
| package cryptor | |||
|
|
|||
| type Cryptor interface { | |||
There was a problem hiding this comment.
How about Cipher? I think it's more appropriate name. I googled Cryptor and it seems not be used that much.
https://encyclopedia.kaspersky.com/glossary/cryptor/
There was a problem hiding this comment.
renamed into Cipher
jakubdyszkiewicz
approved these changes
Sep 3, 2019
yskopets
force-pushed
the
feature/add-secret-store
branch
from
a233cfe
to
83bcb7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation:
changes:
SecretResource(should NOT be accessible via REST API)SecretStoreabstractionk8s-specific implementation ofSecretStore- to persist data in k8s Secretsuniversalimplementation ofSecretStore- to persist data in the underlying ResourceStoreSecretManagerabstraction - to encrypt data before saving them toSecretStore- to be used inuniversalmode withPostgresstore