Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(kuma-cp) fix V3 deprecation usages #1442

Merged
merged 1 commit into from
Jan 25, 2021
Merged

chore(kuma-cp) fix V3 deprecation usages #1442

merged 1 commit into from
Jan 25, 2021

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Jan 19, 2021 •
edited

Summary

Fixes V3 deprecation usages that were introduced in Envoy 1.17.
Reenabled unit tests for access logs.

Documentation

  • No docs, internal changes.

@jakubdyszkiewicz
chore(kuma-cp) fix V3 deprecation usages
1683a33 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz marked this pull request as ready for review January 19, 2021 14:02
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner January 19, 2021 14:02
nickolaev
nickolaev approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@nickolaev nickolaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am glad this fiasco is finally over. Time to move on and forget about it.

@jakubdyszkiewicz jakubdyszkiewicz merged commit a7d78b8 into master Jan 25, 2021
@jakubdyszkiewicz jakubdyszkiewicz deleted the chore/fix-v3-deprecations branch January 25, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickolaev nickolaev nickolaev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jakubdyszkiewicz @nickolaev