control-plane: sds: add built-in CA manager #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yskopets
force-pushed
the
feature/customizable-resource-manager
branch
from
4c3d34d
to
7d676e0
Compare
yskopets
changed the title
yskopets
force-pushed
the
feature/add-builtin-ca-manager
branch
from
c638010
to
79b9ab0
Compare
| return nil | ||
| } | ||
| return errors.Wrapf(err, "failed to delete Builtin CA for a given mesh") | ||
| } |
There was a problem hiding this comment.
Why do we call get before delete?
There was a problem hiding this comment.
Get(..) call has been removed
| if err := m.builtinCaManager.Create(ctx, mesh.Meta.GetName()); err != nil { | ||
| return errors.Wrapf(err, "failed to create Builtin CA for a given mesh") | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we create CA before Mesh? Right now If the CA creation fails, we still have created Mesh.
There was a problem hiding this comment.
Fixed (Built-in CA is now created before Mesh and gets removed if Mesh creation fails)
jakubdyszkiewicz
approved these changes
Sep 6, 2019
yskopets
force-pushed
the
feature/add-builtin-ca-manager
branch
from
199b4a3
to
ce53851
Compare
yskopets
changed the base branch from
feature/customizable-resource-manager
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes:
MeshcreateMeshdelete