Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-cp) inlineString in DataSource #1514

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

jakubdyszkiewicz
Copy link
Contributor

Summary

This PR introduces the capability to provide inline string in DataSource (used for example in ExternalService#tls)

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner February 4, 2021 11:46
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jakubdyszkiewicz jakubdyszkiewicz merged commit 3f93d50 into master Feb 4, 2021
@jakubdyszkiewicz jakubdyszkiewicz deleted the feat/datasource-inline-string branch February 4, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants