feat(kuma-cp) timeouts #1554
Merged
feat(kuma-cp) timeouts #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> # Conflicts: # app/kumactl/pkg/install/k8s/control-plane/helmtemplates_vfsdata.go # go.sum # pkg/plugins/resources/k8s/native/go.sum # pkg/xds/generator/direct_access_proxy_generator_test.go # pkg/xds/generator/inbound_proxy_generator_test.go # pkg/xds/generator/ingress_generator_test.go # pkg/xds/generator/outbound_proxy_generator_test.go # pkg/xds/generator/proxy_template_profile_source_test.go # pkg/xds/generator/proxy_template_test.go # pkg/xds/generator/testdata/admin/01.envoy-config.golden.yaml # pkg/xds/generator/testdata/direct-access/03.envoy-config.golden.yaml # pkg/xds/generator/testdata/direct-access/04.envoy-config.golden.yaml # pkg/xds/generator/testdata/inbound-proxy/3-envoy-config.golden.yaml # pkg/xds/generator/testdata/inbound-proxy/4-envoy-config.golden.yaml # pkg/xds/generator/testdata/ingress/01.envoy.golden.yaml # pkg/xds/generator/testdata/ingress/03.envoy.golden.yaml # pkg/xds/generator/testdata/ingress/04.envoy.golden.yaml # pkg/xds/generator/testdata/outbound-proxy/03.envoy.golden.yaml # pkg/xds/generator/testdata/outbound-proxy/04.envoy.golden.yaml # pkg/xds/generator/testdata/outbound-proxy/05.envoy.golden.yaml # pkg/xds/generator/testdata/outbound-proxy/06.envoy.golden.yaml # pkg/xds/generator/testdata/outbound-proxy/cluster-dots.envoy.golden.yaml # pkg/xds/generator/testdata/profile-source/1-envoy-config.golden.yaml # pkg/xds/generator/testdata/profile-source/2-envoy-config.golden.yaml # pkg/xds/generator/testdata/profile-source/3-envoy-config.golden.yaml # pkg/xds/generator/testdata/profile-source/4-envoy-config.golden.yaml # pkg/xds/generator/testdata/template-proxy/1-envoy-config.golden.yaml # pkg/xds/generator/testdata/tracing/zipkin.envoy-config.golden.yaml # pkg/xds/generator/tracing_generator_test.go
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
| RequestTimeout: durationpb.New(15 * time.Second), | ||
| }, | ||
| Grpc: &mesh_proto.Timeout_Conf_Grpc{ | ||
| StreamIdleTimeout: durationpb.New(5 * time.Minute), |
There was a problem hiding this comment.
Is it intentional that max_stream_duration is missing?
There was a problem hiding this comment.
Yes, by default max_stream_duration is not set in the Envoy, so I think it's okay to skip it for the default Timeout policy
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
|
@jakubdyszkiewicz that's a really nice idea to test it with FaultInjection, I had a plan to do it in a separate PR to not overload this PR |
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> # Conflicts: # pkg/plugins/resources/k8s/native/go.sum
jakubdyszkiewicz
approved these changes
Feb 18, 2021
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> # Conflicts: # app/kumactl/pkg/install/k8s/control-plane/helmtemplates_vfsdata.go # pkg/xds/generator/testdata/direct-access/03.envoy-config.golden.yaml # pkg/xds/generator/testdata/direct-access/04.envoy-config.golden.yaml # pkg/xds/generator/testdata/ingress/01.envoy.golden.yaml # pkg/xds/generator/testdata/ingress/03.envoy.golden.yaml # pkg/xds/generator/testdata/ingress/04.envoy.golden.yaml # pkg/xds/generator/testdata/outbound-proxy/03.envoy.golden.yaml # pkg/xds/generator/testdata/outbound-proxy/04.envoy.golden.yaml # pkg/xds/generator/testdata/outbound-proxy/05.envoy.golden.yaml # pkg/xds/generator/testdata/outbound-proxy/06.envoy.golden.yaml # pkg/xds/generator/testdata/outbound-proxy/cluster-dots.envoy.golden.yaml # pkg/xds/generator/testdata/profile-source/1-envoy-config.golden.yaml # pkg/xds/generator/testdata/profile-source/2-envoy-config.golden.yaml # pkg/xds/generator/testdata/profile-source/3-envoy-config.golden.yaml # pkg/xds/generator/testdata/profile-source/4-envoy-config.golden.yaml # pkg/xds/generator/transparent_proxy_generator_test.go
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Current PR introduces a new policy Timeout. It's created according to the proposal.
TODO in the scope of this PR