Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp) creation and modification time for postgres #1557

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

lobkovilya
Copy link
Contributor

Full changelog

  • Properly set field CreationTime and ModificationTime
  • In Postgres we use Timestamp format which doesn't include timezone and expect time to be in UTC, this PR converts the time to UTC and back when reading/writing from Postgres

Issues resolved

Fix #1556

Documentation

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya requested a review from a team as a code owner February 12, 2021 14:45
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lobkovilya lobkovilya merged commit 1abcd97 into master Feb 16, 2021
@lobkovilya lobkovilya deleted the fix/postgres-time branch February 16, 2021 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Global setup resource age is 0
4 participants