Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*) degraded status in insights #1563

Merged
merged 9 commits into from
Feb 23, 2021

Conversation

bartsmykla
Copy link
Contributor

@bartsmykla bartsmykla commented Feb 15, 2021

Summary

Adding partially degraded statuses for ServiceInsights and MeshInsights

Examples:

{
 "type": "MeshInsight",
 "name": "default",
 "creationTime": "2020-11-17T08:10:24.886346Z",
 "modificationTime": "2020-11-17T19:21:39.912878Z",
 "lastSync": "2020-11-17T12:21:39.912877Z",
 "dataplanes": {
  "total": 4,
  "online": 2,
  "partially_degraded": 1,
  "offline": 1
 },
 "policies": {
  "Secret": {
   "total": 1
  },
  "TrafficPermission": {
   "total": 1
  },
  "TrafficRoute": {
   "total": 1
  }
 },
 "dpVersions": {
  "kumaDp": {
   "1.0.0-rc2-119-g50e35395": {
    "total": 1,
    "online": 1
   },
   "1.0.4": {
    "total": 2,
    "online": 1,
    "partially_degraded": 1
   },
   "unknown": {
    "total": 1,
    "online": 1
   }
  },
  "envoy": {
   "1.15.0": {
    "total": 2,
    "online": 2
   },
   "unknown": {
    "total": 1,
    "online": 1
   }
  }
 }
}
{
 "type": "ServiceInsight",
 "mesh": "default",
 "name": "backend",
 "creationTime": "2020-10-12T09:40:27.224648+03:00",
 "modificationTime": "2020-10-12T09:40:27.224648+03:00",
 "status": "partially_degraded",
 "dataplanes": {
  "online": 1,
  "offline": 1,
  "total": 3
 }
}

- Added `partially degraded` status for service and mesh insights

Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla requested a review from a team as a code owner February 15, 2021 12:15
@nickolaev nickolaev changed the title Feat/degraded status in insights feat(*) degraded status in insights Feb 15, 2021
Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla
Copy link
Contributor Author

Please wait till I will change the docs as I introduced breaking'ish change for service insights after @lobkovilya pointed mistake in my code

@bartsmykla bartsmykla marked this pull request as draft February 16, 2021 11:41
Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla marked this pull request as ready for review February 23, 2021 08:29
@bartsmykla
Copy link
Contributor Author

PR with the docs is ready: kumahq/kuma-website#378

@bartsmykla bartsmykla merged commit dc7f41f into kumahq:master Feb 23, 2021
@bartsmykla bartsmykla deleted the feat/degraded-status-in-insights branch February 23, 2021 10:27
@bartsmykla
Copy link
Contributor Author

Now when it's merged @nickolaev could you also look at: kumahq/kuma-website#378 ?

@bartsmykla bartsmykla restored the feat/degraded-status-in-insights branch February 24, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants