Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xds) Add support for UDP Listeners #1568

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

lahabana
Copy link
Contributor

Make InboundListener configurable with the protocol.
This will be necessary to add a DNSFilter for the local DNS feature

Make `InboundListener` configurable with the protocol.
This will be necessary to add a DNSFilter for the local DNS feature

Signed-off-by: Charly Molter <charly@koyeb.com>
@lahabana lahabana requested a review from a team as a code owner February 16, 2021 19:40
@subnetmarco
Copy link
Contributor

Does this also require the introduction of protocol: udp in our data plane proxies?

@lahabana
Copy link
Contributor Author

This is only exposing UDP protocol internally to the CP, there's no public api to set the protocol as UDP (.i.e this is not first class support for UDP in Kuma)

Copy link
Contributor

@nickolaev nickolaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward and follows #950, so should make it easier to integrate it.

@nickolaev nickolaev merged commit 57df1c2 into kumahq:master Feb 17, 2021
@lahabana lahabana deleted the feat/udpListener branch March 29, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants