control-plane: secured listeners #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yskopets
reviewed
Sep 6, 2019
components/konvoy-control-plane/pkg/xds/server/testdata/2-dataplane.yaml
Outdated
Show resolved
Hide resolved
yskopets
reviewed
Sep 6, 2019
components/konvoy-control-plane/pkg/xds/generator/inbound_proxy_generator_test.go
Outdated
Show resolved
Hide resolved
yskopets
approved these changes
Sep 6, 2019
yskopets
force-pushed
the
feature/add-sds-ca-provider
branch
from
59ffa80
to
ef53f97
Compare
yskopets
force-pushed
the
feature/secured-inbound-listener-v3
branch
from
5070d4f
to
85a6bda
Compare
yskopets
changed the base branch from
feature/add-sds-ca-provider
to
feature/add-sds-identity-provider
jakubdyszkiewicz
force-pushed
the
feature/secured-inbound-listener-v3
branch
from
85a6bda
to
8e7feca
Compare
jakubdyszkiewicz
changed the base branch from
feature/add-sds-identity-provider
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About tests. This change broke many tests.
proxy_template_test.gowhich was over 1500 lines, which would become probably over 2000 after my changes. Moved test cases to files and split different ResourceGenerators to different files.(
proxy_template_raw_source_test.goandtransparent_proxy_generator_test.gotest cases are still in the files)CI will fail as we secure listeners by default for this moment.