feat(kuma-cp) global secrets #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
1 task
lobkovilya
reviewed
Feb 24, 2021
| func (s *globalSecretManager) DeleteAll(ctx context.Context, secrets model.ResourceList, fs ...core_store.DeleteAllOptionsFunc) error { | ||
| list := &secret_model.SecretResourceList{} | ||
| opts := core_store.NewDeleteAllOptions(fs...) | ||
| if err := s.secretStore.List(context.Background(), list, core_store.ListByMesh(opts.Mesh)); err != nil { |
There was a problem hiding this comment.
I'm pretty sure it will work, but I'd better get rid of any mentioning of opts.Mesh in the global secret manager. Maybe we can replace opts.Mesh with core_model.NoMesh here?
There was a problem hiding this comment.
good point. Removed ListByMesh althogether (which is equivalent of ListByMesh(NoMesh))
bartsmykla
approved these changes
Feb 24, 2021
Comment on lines
+77
to
+82
| if trr, ok := r.(*GlobalSecretResource); ok { | ||
| l.Items = append(l.Items, trr) | ||
| return nil | ||
| } else { | ||
| return model.ErrorInvalidItemType((*GlobalSecretResource)(nil), r) | ||
| } |
There was a problem hiding this comment.
maybe:
Suggested change
| if trr, ok := r.(*GlobalSecretResource); ok { | |
| l.Items = append(l.Items, trr) | |
| return nil | |
| } else { | |
| return model.ErrorInvalidItemType((*GlobalSecretResource)(nil), r) | |
| } | |
| if trr, ok := r.(*GlobalSecretResource); ok { | |
| l.Items = append(l.Items, trr) | |
| return nil | |
| } | |
| return model.ErrorInvalidItemType((*GlobalSecretResource)(nil), r) |
There was a problem hiding this comment.
Those two nits are valid points, but I want this file to be consistent with other Resource files, so I'd prefer to leave it as is
Comment on lines
+42
to
+47
| if !ok { | ||
| return errors.New("invalid type of spec") | ||
| } else { | ||
| t.Spec = value | ||
| return nil | ||
| } |
There was a problem hiding this comment.
maybe:
Suggested change
| if !ok { | |
| return errors.New("invalid type of spec") | |
| } else { | |
| t.Spec = value | |
| return nil | |
| } | |
| if !ok { | |
| return errors.New("invalid type of spec") | |
| } | |
| t.Spec = value | |
| return nil |
nickolaev
approved these changes
Feb 24, 2021
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
jakubdyszkiewicz
force-pushed
the
feat/global-secrets-v2
branch
from
655f394
to
72dc081
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introducing the concept of Global Scoped Secret.
Until now, every secret was a part of a mesh. Now the secret can be either global scoped or mesh scoped.
Global scoped secret cannot be used as mesh scoped (ie. you cannot create a global scoped secret with CA and use it across many meshes).
API
GET /global-secrets/{name} to list single global secret
PUT /global-secrets/{name} to put single global secret
DELETE /global-secrets/{name} to delete single global secret
kumactl
kumactl get global-secrets
kumactl get global-secret sample-global-secret
kumactl delete global-secret sample-global-secret
No breaking changes.
Documentation