-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kuma-cp) introduce 'healthy_panic_theshold' for HealthCheck policy #1625
Conversation
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
ZoneAwareLbConfig: &envoy_api.Cluster_CommonLbConfig_ZoneAwareLbConfig{}, | ||
} | ||
} | ||
cluster.CommonLbConfig.GetZoneAwareLbConfig().FailTrafficOnPanic = value.GetValue() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So is this the only other option if cluster.CommonLbConfig.GetLocalityWeightedLbConfig()
is empty?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is a good point, now there are only 2 options, but it might change. So I added nil-check, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit, except that lgtm
} | ||
|
||
BeforeEach(func() { | ||
universalCluster = NewUniversalCluster(NewTestingT(), Kuma1, Verbose) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be Verbose
, when in other tests we are using Silent
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I did it for debugging, changed to Silent
thanks!
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Summary
Extend Kuma HealthCheck policy with 2 optional fields:
Documentation