Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(kuma-cp) proposal to extend CircuitBreaker #1655

Merged
merged 1 commit into from
Mar 15, 2021
Merged

docs(kuma-cp) proposal to extend CircuitBreaker #1655

merged 1 commit into from
Mar 15, 2021

Conversation

lobkovilya
Copy link
Contributor

Summary

Proposal to extend CircuitBreaker policy

@lobkovilya
feat(kuma-cp) extend CircuitBreaker
e1f4ff4 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya requested a review from a team as a code owner March 9, 2021 15:41
jakubdyszkiewicz
jakubdyszkiewicz approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when implementing, make sure you add proper Grafana charts

@jakubdyszkiewicz
Copy link
Contributor

also, should we add a default CircuitBreaker policy with thresholds?

@lobkovilya lobkovilya merged commit fd4bbe4 into master Mar 15, 2021
@lobkovilya lobkovilya deleted the docs/proposal-extend-circuit-breaker branch March 15, 2021 17:49
@lobkovilya lobkovilya mentioned this pull request Mar 15, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickolaev nickolaev nickolaev approved these changes

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lobkovilya @jakubdyszkiewicz @nickolaev