control-plane: access logs #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubdyszkiewicz
force-pushed
the
feature/access-logs
branch
2 times, most recently
from
2c23e9a
to
a1b6082
Compare
yskopets
reviewed
Sep 10, 2019
app/kumactl/cmd/get/get_meshes.go
Outdated
| @@ -56,9 +56,14 @@ func printMeshes(meshes *mesh.MeshResourceList, out io.Writer) error { | |||
| } | |||
| mesh := meshes.Items[i] | |||
|
|
|||
| accessLogs := table.OnOff(mesh.Spec.GetLogging().GetAccessLogs().GetEnabled()) | |||
| if mesh.Spec.GetLogging().GetAccessLogs().GetEnabled() { | |||
| accessLogs += " (" + mesh.Spec.GetLogging().GetAccessLogs().FilePath + ")" | |||
There was a problem hiding this comment.
should be GetFilePath() for safety
app/kumactl/cmd/get/get_meshes.go
Outdated
| @@ -46,7 +46,7 @@ func newGetMeshesCmd(pctx *getContext) *cobra.Command { | |||
|
|
|||
| func printMeshes(meshes *mesh.MeshResourceList, out io.Writer) error { | |||
| data := printers.Table{ | |||
| Headers: []string{"NAME", "MTLS"}, | |||
| Headers: []string{"NAME", "MTLS", "DP ACCESS LOGS"}, | |||
There was a problem hiding this comment.
Can we rename it into ACCESS LOGS ?
There was a problem hiding this comment.
It was ACCESS LOGS initially, but Marco wanted to add DP
pkg/xds/envoy/envoy_test.go
Outdated
| @@ -118,6 +118,38 @@ var _ = Describe("Envoy", func() { | |||
| '@type': type.googleapis.com/envoy.config.filter.network.tcp_proxy.v2.TcpProxy | |||
| cluster: localhost:8080 | |||
| statPrefix: localhost:8080 | |||
| `, | |||
| }), | |||
| Entry("without transparent proxying", testCase{ | |||
There was a problem hiding this comment.
test name could be more relevant
pkg/xds/server/components.go
Outdated
| @@ -62,7 +62,9 @@ func DefaultDataplaneSyncTracker(rt core_runtime.Runtime, reconciler SnapshotRec | |||
| envoyCtx := xds_context.Context{ | |||
| ControlPlane: envoyCpCtx, | |||
| Mesh: xds_context.MeshContext{ | |||
| TlsEnabled: meshList.Items[0].Spec.Mtls.Enabled, | |||
| TlsEnabled: meshList.Items[0].Spec.GetMtls().Enabled, | |||
There was a problem hiding this comment.
should be GetEnabled() for safety
jakubdyszkiewicz
force-pushed
the
feature/access-logs
branch
from
a1b6082
to
99083ec
Compare
yskopets
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Access logs that shows traffic. Due to L4, we are very limited what we can display
Format for now
refernce: https://www.envoyproxy.io/docs/envoy/latest/configuration/observability/access_log
Once we have outbound CDS, we can try
%UPSTREAM_CLUSTER%