kumactl: improved error handling #127 #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yskopets
reviewed
Sep 7, 2019
| if statusCode != http.StatusOK { | ||
| return nil, errors.Errorf("unexpected status code: %d", statusCode) | ||
| if statusCode != 200 { | ||
| return nil, errors.Errorf("(%d): %s", statusCode, string(b)) |
There was a problem hiding this comment.
Why this error message is better ?
There was a problem hiding this comment.
Because it shows error from the server. For example, when mesh is not found, previously we've got:
unexpected status code: 400
now we will see
(400): Mesh of name pilot is not found
yskopets
approved these changes
Sep 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now pass the error message from the server.
Errors from protobuf library are not very informative :/ It's hard to deduce with which field there is a problem.