Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sds: fix issues with auto-generated TLS cert for SDS server #177

Merged
merged 1 commit into from
Sep 8, 2019
Merged

sds: fix issues with auto-generated TLS cert for SDS server #177

merged 1 commit into from
Sep 8, 2019

Conversation

yskopets
Copy link
Contributor

@yskopets yskopets commented Sep 8, 2019

changes:

  • apparently, Envoy's SDS client (Google gRPC) does require DNS SAN in a X509 cert of an SDS server
  • auto-generate SDS cert for Postgres-based deployment as well
  • use RSA keys for SDS certs (for consistency with in-mesh certs and similar troubleshooting)

@yskopets yskopets added this to the 0.1 milestone Sep 8, 2019
@yskopets yskopets force-pushed the fix/issues-with-tls-cert-for-sds-server branch from 0f74933 to 5991339 Compare September 8, 2019 18:06
@yskopets yskopets changed the base branch from renaming/kuma-injector to master September 8, 2019 19:46
@yskopets yskopets merged commit 90c459d into master Sep 8, 2019
@yskopets yskopets deleted the fix/issues-with-tls-cert-for-sds-server branch September 10, 2019 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yskopets @jakubdyszkiewicz