feat(kuma-cp) more flexible /versions + new GUI #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of direclty specifying all versions explicitly, we can use common semver patterns like `^` or `~` now Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
…le-versions-endpoint
…le-versions-endpoint
Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
jakubdyszkiewicz
approved these changes
Apr 21, 2021
mergify bot
pushed a commit
that referenced
this pull request
Apr 21, 2021
* feat(kuma-cp) more flexible /versions + new GUI Instead of direclty specifying all versions explicitly, we can use common semver patterns like `^` or `~` now (cherry picked from commit 182188d) # Conflicts: # app/kumactl/pkg/install/k8s/control-plane/helmtemplates_vfsdata.go
nickolaev
pushed a commit
that referenced
this pull request
Apr 21, 2021
* feat(kuma-cp) more flexible /versions + new GUI Instead of direclty specifying all versions explicitly, we can use common semver patterns like `^` or `~` now (cherry picked from commit 182188d) # Conflicts: # app/kumactl/pkg/install/k8s/control-plane/helmtemplates_vfsdata.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of directly specifying all versions explicitly,
we can use common semver patterns like
^or~nowBy setting:
{ "^1.1.0": { "envoy": "~1.17.0" } }we are specifying that all versions with higher minor and patch will be expected to work with envoy
~1.17.0, so1.1.3is fine, same with1.2.0or1.15.15but not1.0.0or1.0.5