fix(prometheus-sd) namespace source names for v1 API #1896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: austin ce <austin.cawley@gmail.com>
austince
force-pushed
the
fix/prometheus-sd/source-ns
branch
2 times, most recently
from
89f1acb
to
1a0931e
Compare
|
Yes, it works now! Looks like the problem happened because of the name's collision. Feel free to bump default version back to |
Signed-off-by: austin ce <austin.cawley@gmail.com>
|
@lobkovilya all ready, if you have time to take a look |
nickolaev
approved these changes
Apr 29, 2021
|
@nickolaev did we add MADS v1 to in stable yet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Though
targetgroup.Group.Sourceis constant in the native Prometheus SD implementations, the kuma-prometheus-sddoes target diff tracking using this field in order to remove groups from the written file, and expects it to be unique.
Full changelog
Issues resolved
Fixes #1886
Documentation