fix(kumactl) mads-server graceful shutdown #1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
jakubdyszkiewicz
approved these changes
Apr 29, 2021
austince
approved these changes
Apr 29, 2021
mergify bot
pushed a commit
that referenced
this pull request
Apr 30, 2021
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> (cherry picked from commit 1a54668) # Conflicts: # pkg/mads/server/server.go
|
@jakubdyszkiewicz this can't be backported because MADS v1 is not in stable yet |
|
Good point, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
During graceful shutdown
mads-serverprinted errors.For some reason
cmux.Servereturnsuse of closed network connection, instead ofcmux.ErrListenerClosed, probably it relates to soheilhy/cmux#39