chore(test) add test for HealthCheck policy #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
| // wait cluster 'test-server' to be marked as unhealthy | ||
| Eventually(func() bool { | ||
| cmd := []string{"/bin/bash", "-c", "\"curl localhost:30001/clusters | grep test-server\""} | ||
| stdout, _, err := cluster.ExecWithRetries("", "", "dp-demo-client", cmd...) |
There was a problem hiding this comment.
maybe just Exec? Do we need retries on top of retries?
There was a problem hiding this comment.
Technically these are different retries: ExecWithRetries will retry if you failed to exec cmd, ssh problem, or something like that, whereas Eventually waits correct response from localhost:30001/clusters
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
jakubdyszkiewicz
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Besides the test current PR introduces a new binary
test-server. It's built usingcobraso could be easily extended for other purposes. Now it has only one command:which runs a server that can respond to health checker messages over TCP.
This binary is embedded into
kuma-universalimage. I don't think we have to build it (andkuma-universalas well) when running general targets. So the targets like:make buildmake imagesmake docker/buildmake docker/loadmake docker/saveshould not build auxiliary binaries and images that are needed only for testing. Probably we have to create separate targets for all binaries that we're not shipping like
make test/build,make test/images, or something like this. Right now I just explicitly callmake docker/build/kuma-universalwhere needed.Maybe there are should be 2 types of targets:
And the general target for all
build: release/build test/build@kumahq/kuma-maintainers what do you think?
Full changelog
test-serverIssues resolved
Fix #XXX
Documentation