fix(kuma-cp) manage and warn on control plane file limits #2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The control plane needs a file descriptor limit high enough to be able to accept a useful number of connections from clients. Automatically raise the soft limit at startup, and log if the limit still seems too low. Signed-off-by: James Peach <james.peach@konghq.com>
nickolaev
approved these changes
May 28, 2021
|
please pay attention to |
|
Argh, I forgot to remove debug logs, nice catch!
… On May 28, 2021, at 5:53 PM, Jakub Dyszkiewicz ***@***.***> wrote:
@jakubdyszkiewicz commented on this pull request.
In pkg/util/os/limits.go:
> +package os
+
+import (
+ "fmt"
+ "log"
+
+ "golang.org/x/sys/unix"
+)
+
+func setFileLimit(n uint64) error {
+ limit := unix.Rlimit{
+ Cur: n,
+ Max: n,
+ }
+
+ log.Printf("setting limit to %d", n)
Please use our logger (core.Log) instead of "log"
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
* Remove debugging log print * Refactor test to handle already maxed out file limits Signed-off-by: James Peach <james.peach@konghq.com>
|
@jakubdyszkiewicz @lobkovilya I addressed the review feedback, PTAL. |
jakubdyszkiewicz
approved these changes
Jun 2, 2021
bartsmykla
pushed a commit
to bartsmykla/kuma
that referenced
this pull request
Jun 7, 2021
The control plane needs a file descriptor limit high enough to be able to accept a useful number of connections from clients. Automatically raise the soft limit at startup, and log if the limit still seems too low. Signed-off-by: James Peach <james.peach@konghq.com>
bartsmykla
pushed a commit
to bartsmykla/kuma
that referenced
this pull request
Jun 7, 2021
The control plane needs a file descriptor limit high enough to be able to accept a useful number of connections from clients. Automatically raise the soft limit at startup, and log if the limit still seems too low. Signed-off-by: James Peach <james.peach@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The control plane needs a file descriptor limit high enough to be able
to accept a useful number of connections from clients. Automatically
raise the soft limit at startup, and log if the limit still seems too low.
Full changelog
Issues resolved
N/A
Documentation
N/A
Testing