Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-dp) minor editorial improvements to error messages #2060

Merged
merged 3 commits into from
Jun 4, 2021
Merged

fix(kuma-dp) minor editorial improvements to error messages #2060

merged 3 commits into from
Jun 4, 2021

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented May 28, 2021

Signed-off-by: James Peach james.peach@konghq.com

Summary

Minor editorial improvements to error messages.

Full changelog

N/A

Issues resolved

N/A

Documentation

N/A

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Signed-off-by: James Peach <james.peach@konghq.com>
@jpeach jpeach requested a review from a team as a code owner May 28, 2021 06:46
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jakubdyszkiewicz
Copy link
Contributor

Please fix should fail when name and mesh is provided with dataplane definition 🙏

@jpeach jpeach merged commit dfa10f0 into kumahq:master Jun 4, 2021
@jpeach jpeach deleted the fix/dp-error-msg branch June 4, 2021 06:23
bartsmykla pushed a commit to bartsmykla/kuma that referenced this pull request Jun 7, 2021
)

Signed-off-by: James Peach <james.peach@konghq.com>
bartsmykla pushed a commit to bartsmykla/kuma that referenced this pull request Jun 7, 2021
)

Signed-off-by: James Peach <james.peach@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants