feat(kuma-cp) TrafficRoute L7 implementation #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
…l7-impl Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
lobkovilya
reviewed
May 31, 2021
| envoy_common.WithExternalService(isExternalService), | ||
| ) | ||
|
|
||
| if name, ok := clusterCache[cluster.Hash()]; ok { |
There was a problem hiding this comment.
I'm not sure I understand it. Hash is calculated as $name-$tags, so if hashes are equal then names are equal as well. That's why I don't understand why do we call cluster.SetName(name)
There was a problem hiding this comment.
The weights might be different. So it's either take existing cluster, copy it and change the weight or take a new one and override the name. The rest should be the same
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implementation of L7 routing.
Issues resolved
Fix #885
Documentation
modifysectionTesting