feat(kuma-cp) TrafficRoute L7 modify #2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
jpeach
reviewed
Jun 1, 2021
jpeach
reviewed
Jun 1, 2021
jpeach
reviewed
Jun 1, 2021
jpeach
reviewed
Jun 1, 2021
jpeach
reviewed
Jun 1, 2021
| if add.GetValue() == "" { | ||
| err.AddViolationAt(pathBuilder.Field("add").Index(i).Field("value"), "cannot be empty") | ||
| } | ||
| } |
There was a problem hiding this comment.
Is it legal to modify the "Host" or ":authority" headers here?
There was a problem hiding this comment.
it is, but host section takes precedence
There was a problem hiding this comment.
I think we should enforce the separation. IIUC, envoy will not accept the Host header here because isModifiableHeader and isRemovableHeader will be false for the "Host" header and any ":"-prefixed pseudo header.
If you think it makes sense to take this to a separate issue and PR, I'm OK with that :)
jpeach
reviewed
Jun 2, 2021
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
nickolaev
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Modify section of Traffic Route L7
Issues resolved
Fix #1191
Fix #1634
Fix #1604
Documentation
Testing