Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e) various e2e tooling fixes #2074

Merged
merged 1 commit into from
Jun 4, 2021
Merged

fix(e2e) various e2e tooling fixes #2074

merged 1 commit into from
Jun 4, 2021

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Jun 1, 2021

Summary

  • Prettify the "make help" to improve readability
  • Add docstrings to useful make targets
  • Simplify e2e test package discovery
  • Add some more e2e test documentation
  • Remove most uses of the "kuma-universal:latest" tag
  • Consistently use the Kuma universal image name constant

Full changelog

N/A

Issues resolved

N/A

Documentation

N/A

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

@jpeach jpeach requested a review from a team as a code owner June 1, 2021 07:28
@jpeach
Copy link
Contributor Author

jpeach commented Jun 1, 2021

I'm not convinced the kuma-universal:latest changes are correct, at minimum they are incomplete. Posing a PR to let CI chew on it a bit :)

* Prettify the "make help" to improve readability
* Add docstrings to useful make targets
* Add some more e2e test documentation
* Consistently use the Kuma universal image name constant

Signed-off-by: James Peach <james.peach@konghq.com>
@jpeach
Copy link
Contributor Author

jpeach commented Jun 2, 2021

I'm not convinced the kuma-universal:latest changes are correct, at minimum they are incomplete. Posing a PR to let CI chew on it a bit :)

I removed some changes which were breaking e2e tests. That was a learning experience 😂

@jpeach jpeach merged commit 8589607 into kumahq:master Jun 4, 2021
@jpeach jpeach deleted the fix-e2-various-tooling branch June 4, 2021 06:05
bartsmykla pushed a commit to bartsmykla/kuma that referenced this pull request Jun 7, 2021
* Prettify the "make help" to improve readability
* Add docstrings to useful make targets
* Add some more e2e test documentation
* Consistently use the Kuma universal image name constant

Signed-off-by: James Peach <james.peach@konghq.com>
bartsmykla pushed a commit to bartsmykla/kuma that referenced this pull request Jun 7, 2021
* Prettify the "make help" to improve readability
* Add docstrings to useful make targets
* Add some more e2e test documentation
* Consistently use the Kuma universal image name constant

Signed-off-by: James Peach <james.peach@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants