kumadp: bring down size of binary by excluding dependency #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yskopets
reviewed
Sep 9, 2019
| envoy_bootstrap "github.com/envoyproxy/go-control-plane/envoy/config/bootstrap/v2" | ||
| "github.com/gogo/protobuf/proto" | ||
| "github.com/pkg/errors" | ||
| ) | ||
|
|
||
| type BootstrapRequest struct { |
There was a problem hiding this comment.
Instead of duplicating this type, could we just move it into another package ?
Something like github.com/Kong/kuma/pkg/xds/bootstrap/api or github.com/Kong/kuma/pkg/xds/bootstrap/rest
jakubdyszkiewicz
force-pushed
the
chore/dp-size
branch
from
d5f4535
to
4bc081c
Compare
yskopets
approved these changes
Sep 9, 2019
|
Great catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bring down size of binary by excluding dependency from 40MB to 22MB. Good catch @yskopets !