Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests) add namespace to test deployments #2105

Merged
merged 1 commit into from
Jun 24, 2021
Merged

chore(tests) add namespace to test deployments #2105

merged 1 commit into from
Jun 24, 2021

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Jun 7, 2021

Summary

Add the namespace resource to the external service deployment YAML so
that it can be applied as a single step without any manual prerequisites.

Full changelog

N/A

Issues resolved

N/A

Documentation

N/A

Testing

$ k get ns
NAME                 STATUS   AGE
default              Active   2d18h
kube-node-lease      Active   2d18h
kube-public          Active   2d18h
kube-system          Active   2d18h
kuma-system          Active   2d17h
local-path-storage   Active   2d18h
$ k apply -f test/e2e/externalservices/testdata/externalservice-http-server.yaml
namespace/externalservice-namespace created
service/externalservice-http-server created
deployment.apps/externalservice-http-server created
$ k apply -f test/e2e/externalservices/testdata/externalservice-https-server.yaml
namespace/externalservice-namespace unchanged
service/externalservice-https-server created
deployment.apps/externalservice-https-server created

Add the namespace resource to the external service deployment YAML so
that it can be applied as a single step without any manual prerequisites.

Signed-off-by: James Peach <james.peach@konghq.com>
@jpeach jpeach requested a review from a team as a code owner June 7, 2021 00:01
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jpeach jpeach merged commit 5c77fae into kumahq:master Jun 24, 2021
@jpeach jpeach deleted the chore/test-deployment-namespace branch June 24, 2021 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants