Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(e2e) aks push images command fix #2108

Merged
merged 1 commit into from
Jun 7, 2021
Merged

fix(e2e) aks push images command fix #2108

merged 1 commit into from
Jun 7, 2021

Conversation

bartsmykla
Copy link
Contributor

Summary

After changing names of env vars for tests in makefiles
(related to bintray deprecation) we forgot to change the name
of BINTRAY_REGISTRY -> DOCKER_REGISTRY for aks e2e job

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

@bartsmykla
fix(e2e) aks push images command fix
4934da9 
After changing names of env vars for tests in makefiles
(related to bintray deprecation) we forgot to change the name
of BINTRAY_REGISTRY -> DOCKER_REGISTRY for aks e2e job

Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla requested a review from a team as a code owner June 7, 2021 04:47
jpeach
jpeach approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@jpeach jpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartsmykla bartsmykla merged commit ddb94c0 into kumahq:master Jun 7, 2021
@bartsmykla bartsmykla deleted the fix/aks-e2e branch June 7, 2021 05:00
bartsmykla added a commit to bartsmykla/kuma that referenced this pull request Jun 7, 2021
@bartsmykla
fix(e2e) aks push images command fix (kumahq#2108)
68020a0 
After changing names of env vars for tests in makefiles
(related to bintray deprecation) we forgot to change the name
of BINTRAY_REGISTRY -> DOCKER_REGISTRY for aks e2e job

Signed-off-by: Bart Smykla <bartek@smykla.com>
bartsmykla added a commit to bartsmykla/kuma that referenced this pull request Jun 7, 2021
@bartsmykla
fix(e2e) aks push images command fix (kumahq#2108)
14dee69 
After changing names of env vars for tests in makefiles
(related to bintray deprecation) we forgot to change the name
of BINTRAY_REGISTRY -> DOCKER_REGISTRY for aks e2e job

Signed-off-by: Bart Smykla <bartek@smykla.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpeach jpeach jpeach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bartsmykla @jpeach