fix(tests) dev_macos tests #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Test was not working on macos as the max ulimit was set manually - I bumped the number of default "reasonable" value of ulimit for macos to 10240 as it was the default for my system and when it was smaller we couldn't restore the value after our tests because we were trying to set higher value then the "max" we set Signed-off-by: Bart Smykla <bartek@smykla.com>
jakubdyszkiewicz
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
for macos to 10240 as it was the default for my system and
when it was smaller we couldn't restore the value after our tests
because we were trying to set higher value then the "max" we set
Testing