Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*) bump webhooks version #2126

Merged
merged 3 commits into from
Jun 11, 2021
Merged

Conversation

jakubdyszkiewicz
Copy link
Contributor

Summary

Switch between the proper admissionregistration version. We still send AdmissionReview of v1beta1 to keep compatibility with v1beta1. We can switch to v1 when we drop support for v1beta1.

Documentation

  • No docs

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner June 8, 2021 14:51
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

…-version

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
…-version

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz merged commit a5b1897 into master Jun 11, 2021
@jakubdyszkiewicz jakubdyszkiewicz deleted the chore/bump-webhooks-version branch June 11, 2021 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants