fix(kuma-cp) raise the regex program size limit #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though regex program sizes are deprecated, Envoy still enforces the default limit of 100 in the layered runtime. Since users have no reasonable way to predict the size of some arbitrary regex or know how that affect performance, just max out the limit. We have to use UINT32_MAX here, because the actual check truncates the value. We also set a warning limit to an arbitrary size value in case anyone looks at logs and wants to optimize their regexes. This fixes #2103. Signed-off-by: James Peach <james.peach@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Even though regex program sizes are deprecated, Envoy still enforces
the default limit of 100 in the layered runtime. Since users have no
reasonable way to predict the size of some arbitrary regex or know
how that affect performance, just max out the limit. We have to use
UINT32_MAX here, because the actual check truncates the value. We also
set a warning limit to an arbitrary size value in case anyone looks at
logs and wants to optimize their regexes.
Full changelog
N/A
Issues resolved
Fix #2103.
Documentation
N/A
Testing
After applying the new bootstrap, Envoy accepts a regex with a large program size, but logs a warning: