Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*) make check -C api #2141

Merged
merged 3 commits into from
Jun 10, 2021
Merged

fix(*) make check -C api #2141

merged 3 commits into from
Jun 10, 2021

Conversation

nickolaev
Copy link
Contributor

Signed-off-by: Nikolay Nikolaev nikolay.nikolaev@konghq.com

Summary

Fixes check api test in master.

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
@nickolaev nickolaev requested a review from a team as a code owner June 10, 2021 06:39
@jpeach
Copy link
Contributor

jpeach commented Jun 10, 2021

@nickolaev since you are touching the protobufs, could you also apply this change:

diff --git api/mesh/v1alpha1/dataplane.proto api/mesh/v1alpha1/dataplane.proto
index e19af659..c7577961 100644
--- api/mesh/v1alpha1/dataplane.proto
+++ api/mesh/v1alpha1/dataplane.proto
@@ -114,7 +114,7 @@ message Dataplane {
 
       // DEPRECATED: use networking.outbound[].tags
       // Service name.
-      string service = 2 [ (validate.rules).string.hostname = true ];
+      string service = 2 [ (validate.rules).string.hostname = true, deprecated = true ];
 
       // Tags
       map<string, string> tags = 5;

🙏

@jakubdyszkiewicz
Copy link
Contributor

jakubdyszkiewicz commented Jun 10, 2021

can we add this as a part of a commit workflow? It's not the first time we are learning about linter mistake after merge to master. Can be separate PR

Nikolay Nikolaev added 2 commits June 10, 2021 10:56
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
@nickolaev nickolaev merged commit 26726ff into master Jun 10, 2021
@nickolaev nickolaev deleted the fix/make_check_api branch June 10, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants