chore(kuma-cp) Introduce ZoneIngress #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> # Conflicts: # pkg/sds/server/v2/reconciler.go # pkg/sds/server/v2/server.go # test/e2e/deploy/kuma_deploy_universal.go # test/e2e/healthcheck/hybrid/healthcheck_hybrid.go # test/e2e/hybrid/kuma_hybrid.go # test/e2e/hybrid/kuma_hybrid_kube_global.go # test/e2e/trafficpermission/hybrid/traffic_permission_hybrid.go # test/e2e/trafficroute/universal_multizone/traffic_route.go
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
jakubdyszkiewicz
requested changes
Jun 11, 2021
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> # Conflicts: # pkg/kds/global/components.go # test/e2e/trafficroute/universal_multizone/traffic_route.go
| @@ -16,25 +16,25 @@ func validateZoneIngress(path validators.PathBuilder, ingress *mesh_proto.ZoneIn | |||
| return validators.ValidationError{} | |||
| } | |||
| var err validators.ValidationError | |||
| if ingress.GetAdvertisedAddress() == "" && ingress.GetAdvertisedPort() != 0 { | |||
| if ingress.GetNetworking().GetAdvertisedAddress() == "" && ingress.GetNetworking().GetAdvertisedPort() != 0 { | |||
| err.AddViolationAt(path.Field("advertisedAddress"), `has to be defined with advertisedPort`) | |||
There was a problem hiding this comment.
are validator paths correct now?
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
jakubdyszkiewicz
approved these changes
Jun 14, 2021
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Current PR aims to replace dataplane-based Ingress with a new type ZoneIngress.
TODO:
Full changelog
Issues resolved
Fix #XXX
Documentation
Testing