fix(kuma-cp) delete old dataplane-based ingress in PodController #2169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ller Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
lobkovilya
changed the title
pkg/defaults/signing_key.go
Outdated
| return errors.Wrap(err, "could not create a resource") | ||
| } | ||
| log.Info("zone ingress signing key created") |
There was a problem hiding this comment.
you are missing log that signing key already exist. Please make a log consistent with other defaults.
also, it's either zone ingress or Zone Ingress
|
Yep, let me add the test 👍 |
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
jakubdyszkiewicz
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
During the upgrade to Kuma 1.2.0 a new Ingress pod may make a request to the old-versioned PodController.
This will inevitably cause a generation of both Dataplane Ingress resource and Zone Ingress resource.
That's why here we're deleting Dataplane Ingress resource.
Full changelog
Issues resolved
Fix #XXX
Documentation
Testing