Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kuma-cp) backwards compatible metrics #2173

Merged
merged 3 commits into from
Jun 16, 2021

Conversation

jakubdyszkiewicz
Copy link
Contributor

Summary

Introduce compatibility for metrics on old Kuma DP.
The new Kuma DP has a metric hijacker that connects different clusters generated by TrafficRoute. We cannot just generate config with the assumption that there is a hijacker in place.

Documentation

  • No docs, internal changes only

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner June 16, 2021 10:40
pkg/core/xds/metadata.go Show resolved Hide resolved
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz merged commit 7e8f512 into master Jun 16, 2021
@jakubdyszkiewicz jakubdyszkiewicz deleted the chore/backwards-compatible-metrics branch June 16, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants