chore(*) upload coverage data to codecov #2212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2212 +/- ##
=========================================
Coverage ? 15.34%
=========================================
Files ? 45
Lines ? 6320
Branches ? 0
=========================================
Hits ? 970
Misses ? 5270
Partials ? 80 Continue to review full report at Codecov.
|
After integration tests are successful, upload test coverage data to codecov.io. This fixes #2058 Signed-off-by: James Peach <james.peach@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upload coverage data in the integration test job.
There's a little subtlety here that we may want to clean up. Since codecov stores coverage data for comparison, we want the comparison base to be consistent. However, the integration job takes the test targets as parameters, so for the
kuma-commitworkflow we will get coverage for both "integration" and "test" targets, but forkuma-masterandkuma-releaseworkflows the coverage for the "test" target will be omitted.Since the integration job looks like a superset of the test job, we could just combine these into the same job. We need the "test" target for coverage since that's the only thing that crosses module boundaries.
Full changelog
N/A
Issues resolved
Fix #2058
Documentation
N/A
Testing
Checked out the codecov comments below.