chore(kuma-cp) change default number of insights subscriptions #2266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I think we overestimated the usefulness of DataplaneInsights subscriptions history.
Most of the time we check the current subscription for online/offline status, but not the previous ones.
Currently, there is a limit of 10 subscriptions in Insight. This can result in fairly big insight objects. Especially when we have many dataplanes and we are syncing Insights over KDS to global.
I think it's better to change the default subscriptions to 2. One for the current one and one before that.
For ZoneInsight I think we can leave 10, because we usually have only a few zones, maybe tens, not thousands like dataplanes. Also, we don't sync this over KDS.
Documentation
Testing