Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*) remove support for google grpc and dataplane token path #2300

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

jakubdyszkiewicz
Copy link
Contributor

Summary

Due to DNS problems with GoogleGRPC, in Kuma 1.1.2 we changed the way how we do authentication. Previously, we used EnvoyGRPC with a token. We kept the support of the old way due to compatibility with the old Kuma DP.

I think this should stay in master, not backported to release. Technically, we should support upgrades from 1.1.0 to 1.2.0 and this would be a problem.

Documentation

  • No docs

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner July 5, 2021 13:45
@codecov-commenter
Copy link

Codecov Report

Merging #2300 (e092aa8) into master (c682c57) will increase coverage by 0.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2300      +/-   ##
==========================================
+ Coverage   51.46%   51.73%   +0.27%     
==========================================
  Files         893      897       +4     
  Lines       41360    41318      -42     
==========================================
+ Hits        21286    21377      +91     
+ Misses      18053    17897     -156     
- Partials     2021     2044      +23     
Impacted Files Coverage Δ
pkg/core/xds/metadata.go 62.31% <ø> (+0.15%) ⬆️
pkg/xds/bootstrap/generator.go 61.16% <100.00%> (-1.18%) ⬇️
pkg/xds/envoy/tls/v3/tls.go 94.26% <100.00%> (+4.53%) ⬆️
pkg/xds/cache/once/cache.go 86.11% <0.00%> (-8.34%) ⬇️
pkg/xds/context/context.go 68.75% <0.00%> (-6.25%) ⬇️
...kg/plugins/resources/k8s/native/pkg/test/within.go 100.00% <0.00%> (ø)
api/internal/util/proto/proto.go 62.50% <0.00%> (ø)
api/internal/util/proto/types.go 100.00% <0.00%> (ø)
...k8s/native/controllers/proxytemplate_controller.go 0.00% <0.00%> (ø)
api/mesh/v1alpha1/dataplane_helpers.go 77.84% <0.00%> (+1.70%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c682c57...e092aa8. Read the comment docs.

@jakubdyszkiewicz jakubdyszkiewicz merged commit 9fc7f97 into master Jul 5, 2021
@jakubdyszkiewicz jakubdyszkiewicz deleted the chore/remove-dp-token-path branch July 5, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants