Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-cp) CA backend stats in Dataplane and Mesh Insights #2562

Merged
merged 6 commits into from
Aug 19, 2021

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Aug 13, 2021

Summary

Bring CA stats to DataplaneInsights and MeshInsights

Full changelog

  • Add backend to mtls part of DataplaneInsight
  • Add mtlsBackends to MeshInsights which aggregates stats about dataplanes

Issues resolved

No issue

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • No backporting. This will be used for the next major

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner August 13, 2021 11:09
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2021

Codecov Report

Merging #2562 (c77d4fc) into master (a931218) will increase coverage by 0.12%.
The diff coverage is 66.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2562      +/-   ##
==========================================
+ Coverage   52.16%   52.28%   +0.12%     
==========================================
  Files         869      869              
  Lines       48568    48685     +117     
==========================================
+ Hits        25337    25457     +120     
+ Misses      21185    21178       -7     
- Partials     2046     2050       +4     
Impacted Files Coverage Δ
api/mesh/v1alpha1/mesh_insight.pb.go 31.00% <21.42%> (-2.51%) ⬇️
pkg/xds/secrets/ca_provider.go 62.50% <40.00%> (ø)
pkg/xds/secrets/identity_provider.go 64.70% <40.00%> (ø)
pkg/xds/server/callbacks/dataplane_status_sink.go 64.19% <75.00%> (+2.86%) ⬆️
pkg/insights/resyncer.go 67.66% <81.25%> (+3.56%) ⬆️
pkg/xds/secrets/secrets.go 83.33% <86.66%> (+0.53%) ⬆️
api/mesh/v1alpha1/dataplane_insight.pb.go 43.48% <100.00%> (+1.46%) ⬆️
api/mesh/v1alpha1/dataplane_insight_helpers.go 81.48% <100.00%> (+8.83%) ⬆️
app/kumactl/cmd/inspect/inspect_dataplanes.go 94.17% <100.00%> (+1.86%) ⬆️
pkg/test/xds/secrets.go 92.85% <100.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a931218...c77d4fc. Read the comment docs.

Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looking good except the failed copy/paste I think

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz merged commit 7aaebc2 into master Aug 19, 2021
@jakubdyszkiewicz jakubdyszkiewicz deleted the feat/ca-stats branch August 19, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants