-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(virtual-outbound): Add entity for virtual-outbound #2576
Feat(virtual-outbound): Add entity for virtual-outbound #2576
Conversation
Do you want me to merge this without the implem behind it to make things more reviewable? This only registers the new policy everywhere I'll then be able to connect it and add evaluation in a follow up PR. |
It currently doesn't do anything Signed-off-by: Charly Molter <charly.molter@konghq.com>
3afa724
to
92071da
Compare
Codecov Report
@@ Coverage Diff @@
## master #2576 +/- ##
==========================================
- Coverage 52.28% 52.05% -0.24%
==========================================
Files 869 877 +8
Lines 48711 49454 +743
==========================================
+ Hits 25470 25744 +274
- Misses 21193 21644 +451
- Partials 2048 2066 +18
Continue to review full report at Codecov.
|
Signed-off-by: Charly Molter <charly.molter@konghq.com>
92071da
to
0d04d7e
Compare
Signed-off-by: Charly Molter <charly.molter@konghq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
mesh_proto "github.com/kumahq/kuma/api/mesh/v1alpha1" | ||
) | ||
|
||
func tagKeyOrName(parameter *mesh_proto.VirtualOutbound_Conf_TemplateParameter) string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand it correctly we require to add a parameter
entry even if a tag has the same key as a parameter in gotemplate?
So if we have template:
host: {{ .foo }}.{{ .bar }}.{{ .baz }}
and we have DPP with inbound tags:
tags:
foo: value1
bar: value2
baz: value3
Anyway I have to provide parameters section:
host: {{ .foo }}.{{ .bar }}.{{ .baz }}
parameters:
- name: foo
- name: bar
- name: baz
Is it possible to resolve a template without explicit definitions of the parameters if no mapping required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what I wanted at first. However, the set of parameters is what enables me to build the right tags for the outbound on envoy.
I'm not sure it's feasible to extract the keys of the gotemplate but I can have a look.
Signed-off-by: Charly Molter <charly.molter@konghq.com>
613c230
to
48ef66d
Compare
…ma into feat/virtual-outbound-policy Signed-off-by: Charly Molter <charly.molter@konghq.com>
48ef66d
to
14084db
Compare
Summary
Virtual-outbounds enable users to define arbitrary hostnames.
It enables features like:
Documentation
Testing
Backwards compatibility
backport-to-stable
label if the code is backwards compatible. Otherwise, list breaking changes.This relies on changes not backported already.