ci: docker automation #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruv
suggested changes
Sep 16, 2019
gszr
force-pushed
the
ci/docker-automation
branch
7 times, most recently
from
6e50681
to
4d92c89
Compare
gszr
force-pushed
the
ci/docker-automation
branch
from
4d92c89
to
11fb466
Compare
dhruv
approved these changes
Sep 17, 2019
yskopets
reviewed
Sep 18, 2019
| @@ -0,0 +1,12 @@ | |||
| FROM alpine:3.10 | |||
There was a problem hiding this comment.
Docker image should run under a non-root account, e.g. nobody (65534:65534) on alpine
| @@ -0,0 +1,9 @@ | |||
| FROM alpine:3.10 | |||
There was a problem hiding this comment.
Docker image should run under a non-root account, e.g. nobody (65534:65534) on alpine
| @@ -0,0 +1,9 @@ | |||
| FROM alpine:3.10 | |||
There was a problem hiding this comment.
Docker image should run under a non-root account, e.g. nobody (65534:65534) on alpine
| @@ -0,0 +1,10 @@ | |||
| # using Envoy's base to inherit the Envoy binary | |||
There was a problem hiding this comment.
Docker image should run under a non-root account, e.g. nobody (65534:65534) on alpine
| docker_login | ||
|
|
||
| for component in "${KUMA_COMPONENTS[@]}"; do | ||
| msg "Pushing kuma-cp..." |
There was a problem hiding this comment.
Can we change the message to Pushing $component ... ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary