Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Traffic Logging entity #266

Merged
merged 7 commits into from
Sep 20, 2019
Merged

Traffic Logging entity #266

merged 7 commits into from
Sep 20, 2019

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Sep 17, 2019 •
edited

Summary

Created Traffic Log entity.

Full changelog

  • Added new proto file and core entity
  • Added K8S CRD
  • Added kumactl command

@jakubdyszkiewicz jakubdyszkiewicz changed the base branch from master to feature/match-permissions-on-proper-service September 17, 2019 13:06
@jakubdyszkiewicz jakubdyszkiewicz force-pushed the feature/traffic-logging branch 4 times, most recently from 88bd703 to e70be1f Compare September 18, 2019 13:25
@jakubdyszkiewicz jakubdyszkiewicz changed the base branch from feature/match-permissions-on-proper-service to master September 18, 2019 13:25
@yskopets
Copy link
Contributor

@jakubdyszkiewicz

get traffic-loggings is a bit awkward but it's consistent with kubectl. Leave it or rename to get traffic-logging?

indeed, get traffic-loggings is weird. May be get traffic-logs ?

Should we create one Selector proto message and reuse it across all entities?

I think, yes.

@jakubdyszkiewicz jakubdyszkiewicz force-pushed the feature/traffic-logging branch 2 times, most recently from 20ac64e to b685ab2 Compare September 19, 2019 17:19
yskopets
yskopets approved these changes Sep 20, 2019
View reviewed changes
pkg/api-server/definitions/traffic_log.go Outdated
Name: "Traffic Logging",
Path: "traffic-logging",
Path: "traffic-log",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, it should be traffic-logs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed traffic-log -> traffic-logs as well as traffic-permission -> traffic-permissions

@jakubdyszkiewicz jakubdyszkiewicz merged commit f2a12d8 into master Sep 20, 2019
@jakubdyszkiewicz jakubdyszkiewicz deleted the feature/traffic-logging branch December 23, 2019 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yskopets yskopets yskopets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jakubdyszkiewicz @yskopets