Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump github.com/miekg/dns from 1.0.14 to 1.1.43 in /pkg/transparentproxy/istio #2752

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 8, 2021

Bumps github.com/miekg/dns from 1.0.14 to 1.1.25.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot requested a review from a team as a code owner September 8, 2021 08:28
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go labels Sep 8, 2021
@dependabot dependabot bot force-pushed the dependabot/go_modules/pkg/transparentproxy/istio/github.com/miekg/dns-1.1.25 branch 3 times, most recently from e800c35 to d2cba0b Compare September 22, 2021 08:27
Bumps [github.com/miekg/dns](https://github.com/miekg/dns) from 1.0.14 to 1.1.25.
- [Release notes](https://github.com/miekg/dns/releases)
- [Changelog](https://github.com/miekg/dns/blob/master/Makefile.release)
- [Commits](miekg/dns@v1.0.14...v1.1.25)

---
updated-dependencies:
- dependency-name: github.com/miekg/dns
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/pkg/transparentproxy/istio/github.com/miekg/dns-1.1.25 branch from d2cba0b to a8f75e1 Compare September 22, 2021 08:33
… to 1.1.43

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the code we use is in https://github.com/miekg/dns/blob/master/clientconfig.go which hasn't been updated since the previous version.

@michaelbeaumont michaelbeaumont changed the title chore(deps): bump github.com/miekg/dns from 1.0.14 to 1.1.25 in /pkg/transparentproxy/istio chore(deps): bump github.com/miekg/dns from 1.0.14 to 1.1.43 in /pkg/transparentproxy/istio Oct 4, 2021
@michaelbeaumont
Copy link
Contributor

michaelbeaumont commented Oct 4, 2021

Wait this go.mod isn't used
Never mind, it is, kind of. Looks like a workaround to avoid dependency nightmares. Leaving this closed.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 4, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/pkg/transparentproxy/istio/github.com/miekg/dns-1.1.25 branch October 4, 2021 16:49
@bartsmykla bartsmykla restored the dependabot/go_modules/pkg/transparentproxy/istio/github.com/miekg/dns-1.1.25 branch October 13, 2021 04:51
@bartsmykla bartsmykla reopened this Oct 13, 2021
@bartsmykla
Copy link
Contributor

I'm reopening this as it looks like there is a security vulnerability in older version of github.com/miekg/dns, so we should update it

@bartsmykla bartsmykla merged commit e5d92e2 into master Oct 13, 2021
@bartsmykla bartsmykla deleted the dependabot/go_modules/pkg/transparentproxy/istio/github.com/miekg/dns-1.1.25 branch October 13, 2021 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants