feat(kumacp) traffic logging matching #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(kuma-cp) apply traffic logs
yskopets
approved these changes
Sep 23, 2019
pkg/core/logs/matcher.go
Outdated
| // To Match outbound, we need to match service tag of outbound and all tags of any inbound interface | ||
| func matchOutbound(outbound *mesh_proto.Dataplane_Networking_Outbound, inbounds []*mesh_proto.Dataplane_Networking_Inbound, logs []*mesh_core.TrafficLogResource) []*mesh_core.TrafficLogResource { | ||
| matchedLogs := []*mesh_core.TrafficLogResource{} | ||
| for _, perm := range logs { |
| } | ||
|
|
||
| type MatchedLogs struct { | ||
| Outbounds map[string][]*mesh_proto.LoggingBackend |
There was a problem hiding this comment.
as far as I understand, []*mesh_proto.LoggingBackend has no consistent order.
It might cause unnecessary Envoy configuration updates and flaky unit tests.
jakubdyszkiewicz
force-pushed
the
feature/traffic-logging-match
branch
from
03842ea
to
137d788
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First version of traffic logging
Summary
This is first version of traffic logging. It only supports file backend in mesh. The next step is to support sending it to ELK stack.
For the matching part. We match all inbounds and service on outbound and we place access log on outbound listener. For now, we apply all rules that match, we don't choose the most relevant one.
I did not reuse logic from TrafficPermission for now, because it's different. Here we match all inbound + outbound, in TrafficPermission we match destinations to inbounds.
Full changelog
Issues resolved
#271